Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: chrome/browser/notifications/message_center_settings_controller.cc

Issue 163953012: Notification settings for ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Abort test for linux gtk Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_settings_controller.cc
diff --git a/chrome/browser/notifications/message_center_settings_controller.cc b/chrome/browser/notifications/message_center_settings_controller.cc
index d2148a83e4e81233f059b420dacb3d809ed8ac7e..de82030fb48863ac6c918e4bf0802fddcc89874d 100644
--- a/chrome/browser/notifications/message_center_settings_controller.cc
+++ b/chrome/browser/notifications/message_center_settings_controller.cc
@@ -15,6 +15,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/app_icon_loader_impl.h"
#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/history_types.h"
@@ -229,6 +230,12 @@ void MessageCenterSettingsController::GetNotifierList(
continue;
}
+ // Exclude cached ephemeral apps that are not currently running.
+ if (extension->is_ephemeral() &&
+ extensions::util::IsExtensionIdle(extension->id(), profile)) {
+ continue;
+ }
+
NotifierId notifier_id(NotifierId::APPLICATION, extension->id());
notifiers->push_back(new Notifier(
notifier_id,

Powered by Google App Engine
This is Rietveld 408576698