Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1639403004: ARM32 vorr lowering (Closed)

Created:
4 years, 11 months ago by Eric Holk
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Alphabetizing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -3 lines) Patch
M src/IceInstARM32.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/and-vec.ll View 1 chunk +1 line, -1 line 0 comments Download
A tests_lit/assembler/arm32/or-vec.ll View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Eric Holk
4 years, 11 months ago (2016-01-27 21:45:54 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1639403004/diff/1/src/IceTargetLoweringARM32.h File src/IceTargetLoweringARM32.h (right): https://codereview.chromium.org/1639403004/diff/1/src/IceTargetLoweringARM32.h#newcode775 src/IceTargetLoweringARM32.h:775: void _vorr(Variable *Dest, Variable *Src0, Variable *Src1) { ...
4 years, 11 months ago (2016-01-27 22:38:05 UTC) #3
Eric Holk
https://codereview.chromium.org/1639403004/diff/1/src/IceTargetLoweringARM32.h File src/IceTargetLoweringARM32.h (right): https://codereview.chromium.org/1639403004/diff/1/src/IceTargetLoweringARM32.h#newcode775 src/IceTargetLoweringARM32.h:775: void _vorr(Variable *Dest, Variable *Src0, Variable *Src1) { On ...
4 years, 11 months ago (2016-01-27 22:51:47 UTC) #4
Eric Holk
4 years, 11 months ago (2016-01-27 22:56:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cad0b7597cdee839950dae55fccaaa7b54734d79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698