Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1639103002: Remove blink side NPOT/incomplete texture handling. (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove blink side NPOT/incomplete texture handling. We do it in command buffer so it's duplicated validation. BUG=570453 TEST=webgl_conformance R=kbr@chromium.org,bajones@chromium.org Committed: https://crrev.com/72a030e567b12aa843c4e1065e5874750de6a9f2 Cr-Commit-Position: refs/heads/master@{#371711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -26 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTexture.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTexture.cpp View 4 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Zhenyao Mo
This is a first step, relatively simple. PTAL.
4 years, 11 months ago (2016-01-27 00:29:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639103002/1
4 years, 11 months ago (2016-01-27 00:30:28 UTC) #3
Ken Russell (switch to Gerrit)
Excellent. LGTM
4 years, 11 months ago (2016-01-27 00:38:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 01:49:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639103002/1
4 years, 11 months ago (2016-01-27 03:43:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 03:49:52 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 03:50:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72a030e567b12aa843c4e1065e5874750de6a9f2
Cr-Commit-Position: refs/heads/master@{#371711}

Powered by Google App Engine
This is Rietveld 408576698