Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163883006: Add context to generated named and indexed property operations. (Closed)

Created:
6 years, 10 months ago by Mike West
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Add context to generated named and indexed property operations. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167772

Patch Set 1 #

Patch Set 2 : Tests. #

Patch Set 3 : Ugh. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -48 lines) Patch
M LayoutTests/fast/dom/HTMLOptionElement/collection-setter-getter-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/exceptions-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/dataset-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/dataset-xhtml-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/dataset.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/dataset-xhtml.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 2 12 chunks +18 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 1 2 8 chunks +12 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/v8/ExceptionMessages.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/v8/ExceptionMessages.cpp View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M Source/bindings/v8/ExceptionState.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M Source/bindings/v8/ExceptionState.cpp View 1 1 chunk +11 lines, -2 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 32 (0 generated)
Mike West
I somehow skipped named and index property operations when walking through ExceptionState object generation in ...
6 years, 10 months ago (2014-02-20 12:32:52 UTC) #1
haraken
LGTM.
6 years, 10 months ago (2014-02-20 12:38:03 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-20 12:53:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/70001
6 years, 10 months ago (2014-02-20 12:53:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 16:57:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13366
6 years, 10 months ago (2014-02-20 16:57:38 UTC) #6
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-21 05:45:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/70001
6 years, 10 months ago (2014-02-21 05:45:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 08:56:00 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13480
6 years, 10 months ago (2014-02-21 08:56:01 UTC) #10
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-24 08:10:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-24 08:10:22 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 09:52:28 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28561
6 years, 10 months ago (2014-02-24 09:52:28 UTC) #14
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-24 10:01:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-24 10:01:47 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 11:20:29 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28579
6 years, 10 months ago (2014-02-24 11:20:30 UTC) #18
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-24 12:45:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-24 12:45:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-24 13:33:36 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 15:06:11 UTC) #22
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28631
6 years, 10 months ago (2014-02-24 15:06:12 UTC) #23
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-25 07:38:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-25 07:38:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-25 07:48:54 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 12:26:33 UTC) #27
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28879
6 years, 10 months ago (2014-02-25 12:26:33 UTC) #28
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-25 12:38:48 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-25 12:39:07 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/163883006/240001
6 years, 10 months ago (2014-02-25 13:32:49 UTC) #31
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 14:00:11 UTC) #32
Message was sent while issue was closed. 
Change committed as 167772

Powered by Google App Engine
This is Rietveld 408576698