Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: Source/bindings/v8/ExceptionState.cpp

Issue 163883006: Add context to generated named and indexed property operations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Ugh. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/core/dom/DatasetDOMStringMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionState.cpp
diff --git a/Source/bindings/v8/ExceptionState.cpp b/Source/bindings/v8/ExceptionState.cpp
index 37deb8271e68fb117f3141b275d1d729b326f2c2..b8b06377c1c3c077834e0d71aa63151d08856ea4 100644
--- a/Source/bindings/v8/ExceptionState.cpp
+++ b/Source/bindings/v8/ExceptionState.cpp
@@ -131,8 +131,17 @@ String ExceptionState::addExceptionContext(const String& message) const
processedMessage = ExceptionMessages::failedToGet(propertyName(), interfaceName(), message);
else if (m_context == SetterContext)
processedMessage = ExceptionMessages::failedToSet(propertyName(), interfaceName(), message);
- } else if (!propertyName() && interfaceName() && m_context == ConstructionContext) {
- processedMessage = ExceptionMessages::failedToConstruct(interfaceName(), message);
+ } else if (!propertyName() && interfaceName()) {
+ if (m_context == ConstructionContext)
+ processedMessage = ExceptionMessages::failedToConstruct(interfaceName(), message);
+ else if (m_context == EnumerationContext)
+ processedMessage = ExceptionMessages::failedToEnumerate(interfaceName(), message);
+ else if (m_context == IndexedDeletionContext)
+ processedMessage = ExceptionMessages::failedToDeleteIndexed(interfaceName(), message);
+ else if (m_context == IndexedGetterContext)
+ processedMessage = ExceptionMessages::failedToGetIndexed(interfaceName(), message);
+ else if (m_context == IndexedSetterContext)
+ processedMessage = ExceptionMessages::failedToSetIndexed(interfaceName(), message);
}
return processedMessage;
}
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/core/dom/DatasetDOMStringMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698