Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp

Issue 163883006: Add context to generated named and indexed property operations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Ugh. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp
diff --git a/Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp b/Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp
index 8ce42f0484fb9eebf4b612fab0d7a064d357d043..b5004885bf5cac1f0c5f38fa27e71af77248861c 100644
--- a/Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp
+++ b/Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp
@@ -91,7 +91,7 @@ static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> jsValue,
{
TestSpecialOperationsInt* imp = V8TestSpecialOperationsInt::toNative(info.Holder());
V8TRYCATCH_EXCEPTION_VOID(unsigned, propertyValue, toUInt32(jsValue, exceptionState), exceptionState);
- ExceptionState exceptionState(info.Holder(), info.GetIsolate());
+ ExceptionState exceptionState(ExceptionState::IndexedSetterContext, "TestSpecialOperationsInt", info.Holder(), info.GetIsolate());
bool result = imp->anonymousIndexedSetter(index, propertyValue);
if (!result)
return;
@@ -137,7 +137,8 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>
TestSpecialOperationsInt* imp = V8TestSpecialOperationsInt::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);
V8TRYCATCH_EXCEPTION_VOID(unsigned, propertyValue, toUInt32(jsValue, exceptionState), exceptionState);
- ExceptionState exceptionState(info.Holder(), info.GetIsolate());
+ v8::String::Utf8Value namedProperty(name);
+ ExceptionState exceptionState(ExceptionState::SetterContext, *namedProperty, "TestSpecialOperationsInt", info.Holder(), info.GetIsolate());
bool result = imp->anonymousNamedSetter(propertyName, propertyValue);
if (!result)
return;
@@ -155,7 +156,8 @@ static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCal
{
TestSpecialOperationsInt* imp = V8TestSpecialOperationsInt::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- ExceptionState exceptionState(info.Holder(), info.GetIsolate());
+ v8::String::Utf8Value namedProperty(name);
+ ExceptionState exceptionState(ExceptionState::GetterContext, *namedProperty, "TestSpecialOperationsInt", info.Holder(), info.GetIsolate());
bool result = imp->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
@@ -175,7 +177,7 @@ static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& i
{
TestSpecialOperationsInt* imp = V8TestSpecialOperationsInt::toNative(info.Holder());
Vector<String> names;
- ExceptionState exceptionState(info.Holder(), info.GetIsolate());
+ ExceptionState exceptionState(ExceptionState::EnumerationContext, "TestSpecialOperationsInt", info.Holder(), info.GetIsolate());
imp->namedPropertyEnumerator(names, exceptionState);
if (exceptionState.throwIfNeeded())
return;

Powered by Google App Engine
This is Rietveld 408576698