DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp).

DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp).

BUG=

Committed: https://crrev.com/e18e3b2ce08c3c747329aab455ce676fff947da6
Cr-Commit-Position: refs/heads/master@{#371703}

[pfeldman, 2016-01-26 02:10:13]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-01-26 02:45:15]

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html
(right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html:6:
console.error = function() {};
This looks like a bad idea. What if we start getting console errors but would
not see them?

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html
(right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html:27:
function innerPerformActions()
This needs explanation.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/DevToolsHost.h (right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/DevToolsHost.h:80: friend class
FrontendMenuProvider;
This is from another patch.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScript.cpp:123:
ScriptState::Scope scope(m_injectedScriptObject.scriptState());
Why do you need ScriptState::Scope at all?

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScript.cpp:440:
v8::Local<v8::Value>
InjectedScript::callFunctionWithEvalEnabled(ScriptFunctionCall& function, bool&
hadException) const
Non-const references are prohibited.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/JSONValuesForV8.cpp (right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValuesForV8.cpp:18: PassRefPtr<JSONValue>
toJSONValue(v8::Local<v8::Context> context, v8::Local<v8::Value> value, int
maxDepth)
Good change!

[pfeldman, 2016-01-27 01:24:09]

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html
(right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html:6:
console.error = function() {};
On 2016/01/26 02:45:14, dgozman wrote:
> This looks like a bad idea. What if we start getting console errors but would
> not see them?

Done.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html
(right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html:27:
function innerPerformActions()
On 2016/01/26 02:45:14, dgozman wrote:
> This needs explanation.

Done.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/DevToolsHost.h (right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/DevToolsHost.h:80: friend class
FrontendMenuProvider;
On 2016/01/26 02:45:14, dgozman wrote:
> This is from another patch.

Done.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScript.cpp:123:
ScriptState::Scope scope(m_injectedScriptObject.scriptState());
On 2016/01/26 02:45:14, dgozman wrote:
> Why do you need ScriptState::Scope at all?

I need a handle scope and entered context.

https://codereview.chromium.org/1638563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScript.cpp:440:
v8::Local<v8::Value>
InjectedScript::callFunctionWithEvalEnabled(ScriptFunctionCall& function, bool&
hadException) const
On 2016/01/26 02:45:15, dgozman wrote:
> Non-const references are prohibited.

this comes from lhs. i'll fix it.

[dgozman, 2016-01-27 02:07:01]

lgtm

[pfeldman, 2016-01-27 02:09:01]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-01-27 02:09:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638563002/80001

[commit-bot: I haz the power, 2016-01-27 03:26:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-27 03:27:47]

Description was changed from

==========
DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the
InjectedScript.cpp).

BUG=
==========

to

==========
DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the
InjectedScript.cpp).

BUG=

Committed: https://crrev.com/e18e3b2ce08c3c747329aab455ce676fff947da6
Cr-Commit-Position: refs/heads/master@{#371703}
==========

[commit-bot: I haz the power, 2016-01-27 03:27:48]

Patchset 5 (id:??) landed as
https://crrev.com/e18e3b2ce08c3c747329aab455ce676fff947da6
Cr-Commit-Position: refs/heads/master@{#371703}