third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html - Issue 1638563002: DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html

Issue 1638563002: DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready for review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html ('k') | third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../http/tests/inspector/console-test.js"></script>	4 <script src="../../http/tests/inspector/console-test.js"></script>

5 <script>	5 <script>

6	6 console.error = function() {};
	dgozman 2016/01/26 02:45:14 This looks like a bad idea. What if we start getti This looks like a bad idea. What if we start getting console errors but would not see them? pfeldman 2016/01/27 01:24:09 Done. Show quoted text On 2016/01/26 02:45:14, dgozman wrote: > This looks like a bad idea. What if we start getting console errors but would > not see them? Done.
7 var a = {name: "a"};	7 var a = {name: "a"};

8 var b = {name: "b"};	8 var b = {name: "b"};

9 var c = {name: "c"};	9 var c = {name: "c"};

10	10

11 a.formattableBy1 = true;	11 a.formattableBy1 = true;

12 b.formattableBy2 = true;	12 b.formattableBy2 = true;

13 c.formattableBy1 = true;	13 c.formattableBy1 = true;

14 c.formattableBy2 = true;	14 c.formattableBy2 = true;

15	15

16 var formatter1 = {	16 var formatter1 = {

(...skipping 139 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
156 InspectorTest.completeTest();	156 InspectorTest.completeTest();

157 }	157 }

158 }	158 }

159 </script>	159 </script>

160 </head>	160 </head>

161	161

162 <body onload="runTest()">	162 <body onload="runTest()">

163 <p>Tests that console logging dumps properly when there are multiple custom form atters on the page</p>	163 <p>Tests that console logging dumps properly when there are multiple custom form atters on the page</p>

164 </body>	164 </body>

165 </html>	165 </html>

OLD	NEW