third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp - Issue 1638563002: DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

Issue 1638563002: DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptFunctionCall.cpp ('k') | third_party/WebKit/Source/core/inspector/InjectedScript.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

index 1cfdbb98ec6e8659dc51f958dc90046445908c0f..e1d8f2c66cc206d682619ad6e70997b8d783c280 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

@@ -30,11 +30,9 @@

#include "core/inspector/InjectedScriptManager.h"

-#include "bindings/core/v8/BindingSecurity.h"

#include "bindings/core/v8/ScriptValue.h"

+#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8ScriptRunner.h"

-#include "bindings/core/v8/V8Window.h"

-#include "core/frame/LocalDOMWindow.h"

#include "core/inspector/InjectedScriptHost.h"

#include "core/inspector/InjectedScriptNative.h"

#include "core/inspector/v8/V8InjectedScriptHost.h"

@@ -77,13 +75,4 @@ ScriptValue InjectedScriptManager::createInjectedScript(const String& scriptSour

return ScriptValue(inspectedScriptState, injectedScriptValue);

}

-bool InjectedScriptManager::canAccessInspectedWindow(ScriptState* scriptState)

- if (!scriptState->contextIsValid())

- return false;

- ScriptState::Scope scope(scriptState);

- DOMWindow* window = toDOMWindow(scriptState->isolate(), scriptState->context()->Global());

- return window && BindingSecurity::shouldAllowAccessTo(scriptState->isolate(), callingDOMWindow(scriptState->isolate()), window, DoNotReportSecurityError);

} // namespace blink