Fix leak of SkImageGenerator

dm/DMSrcSink.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "DMSrcSink.h"
 #include "SkAndroidCodec.h"
 #include "SkCodec.h"
@@ skipping 261 matching lines @@
     }
 
     // FIXME: Currently we cannot draw unpremultiplied sources.
     if (decodeInfo->alphaType() == kUnpremul_SkAlphaType) {
         *decodeInfo = decodeInfo->makeAlphaType(kPremul_SkAlphaType);
     }
     return true;
 }
 
 Error test_gen(SkCanvas* canvas, SkData* data) {
-    SkImageGenerator* gen = SkCodecImageGenerator::NewFromEncodedCodec(data);
+    SkAutoTDelete<SkImageGenerator> gen = SkCodecImageGenerator::NewFromEncodedCodec(data);
     if (!gen) {
         return "Could not create image generator.";
     }
 
     // FIXME: The gpu backend does not draw kGray sources correctly. (skbug.com/4822)
     // Currently, we will avoid creating a CodecSrc for this case (see DM.cpp).
     SkASSERT(kGray_8_SkColorType != gen->getInfo().colorType());
 
     if (kOpaque_SkAlphaType != gen->getInfo().alphaType() &&
             kRGB_565_SkColorType == canvas->imageInfo().colorType()) {
         return Error::Nonfatal("Skip testing non-opaque images to 565.");
     }
 
-    SkAutoTDelete<SkImage> image(SkImage::NewFromGenerator(gen, nullptr));
+    SkAutoTDelete<SkImage> image(SkImage::NewFromGenerator(gen.detach(), nullptr));

[djsollen, 2016/01/25 18:34:07]

why do you need to detach here?  Does SkImage promise to delete the generator
for us?

     if (!image) {
         return "Could not create image from codec image generator.";
     }
 
     canvas->drawImage(image, 0, 0);
     return "";
 }
 
 Error CodecSrc::draw(SkCanvas* canvas) const {
     SkAutoTUnref<SkData> encoded(SkData::NewFromFileName(fPath.c_str()));
@@ skipping 1038 matching lines @@
             skr.visit<void>(i, drawsAsSingletonPictures);
         }
         SkAutoTUnref<SkPicture> macroPic(macroRec.endRecordingAsPicture());
 
         canvas->drawPicture(macroPic);
         return check_against_reference(bitmap, src, fSink);
     });
 }
 
 }  // namespace DM