Consistency in LayoutReplaced::computeReplacedLogicalWidth()

Consistency in LayoutReplaced::computeReplacedLogicalWidth()

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.

Committed: https://crrev.com/7da2b204600339ea44dece7ca4bc723a97df5e95
Cr-Commit-Position: refs/heads/master@{#371761}

[davve, 2016-01-25 16:43:34]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 16:43:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637473002/1

[commit-bot: I haz the power, 2016-01-25 18:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 18:04:58]

Dry run: This issue passed the CQ dry run.

[davve, 2016-01-26 10:27:18]

Description was changed from

==========
Consistenty in LayoutReplaced::computeReplacedLogicalWidth()

Respect min/max-widths for preferred widths of auto sized replaced
content. From css-sizing-3 editors draft:

 "For replaced elements, the min-content size and max-content size are
  equivalent and correspond to the appropriate dimension of the
  concrete object size returned by the default sizing algorithm
  [CSS3-IMAGES] of the element, calculated with an unconstrained
  specified size.

  The min-content contribution and max-content contribution in each
  axis is the element's specified outer size in that axis, if
  definite; otherwise, they are the min-content size, as specified
  above, plus the element's margin/border/padding in that axis,
  clamped by the element's min and max size properties in that axis."

While it not entierly clear how the preferred width should be
calculated, it should be clamped to min and max size properties and
box-sizing should be taken into account.

BUG=
==========

to

==========
Consistency in LayoutReplaced::computeReplacedLogicalWidth()

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.
==========

[davve, 2016-01-26 10:30:28]

davve@opera.com changed reviewers:
+ eae@chromium.org

[davve, 2016-01-26 10:30:28]

I added this 'return 0;' a year or so ago, but noticed now the
inconsistency of every other return passing through
computeReplacedLogicalWidthRespectingMinMaxWidth. I tried and failed
at exposing this in a test but I'm not confident it's not possible.

If accepted, perhaps it would be useful to break out the
computeReplacedLogicalWidthRespectingMinMaxWidth call into a
surrounding function?

Regarding zero being the correct answer, I asked on www-style today:

https://lists.w3.org/Archives/Public/www-style/2016Jan/0231.html

+Emil for review, feel free to pass along if you feel someone else is a better
match.

[eae, 2016-01-26 22:47:14]

LGTM, this seems reasonable.

[davve, 2016-01-27 07:44:42]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-01-27 07:44:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637473002/1

[commit-bot: I haz the power, 2016-01-27 08:55:44]

Description was changed from

==========
Consistency in LayoutReplaced::computeReplacedLogicalWidth()

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.
==========

to

==========
Consistency in LayoutReplaced::computeReplacedLogicalWidth()

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.
==========

[commit-bot: I haz the power, 2016-01-27 08:55:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 08:57:05]

Description was changed from

==========
Consistency in LayoutReplaced::computeReplacedLogicalWidth()

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.
==========

to

==========
Consistency in LayoutReplaced::computeReplacedLogicalWidth()

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.

Committed: https://crrev.com/7da2b204600339ea44dece7ca4bc723a97df5e95
Cr-Commit-Position: refs/heads/master@{#371761}
==========

[commit-bot: I haz the power, 2016-01-27 08:57:06]

Patchset 1 (id:??) landed as
https://crrev.com/7da2b204600339ea44dece7ca4bc723a97df5e95
Cr-Commit-Position: refs/heads/master@{#371761}