third_party/WebKit/Source/core/layout/LayoutReplaced.cpp - Issue 1637473002: Consistency in LayoutReplaced::computeReplacedLogicalWidth()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

Issue 1637473002: Consistency in LayoutReplaced::computeReplacedLogicalWidth() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp b/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

index 9b1c581c07f54c0d899b39e005744af6ffaae0a9..d7bfd28ff4c44ce748e67bc95c7bde517c74aab4 100644

--- a/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

@@ -576,7 +576,7 @@ LayoutUnit LayoutReplaced::computeReplacedLogicalWidth(ShouldComputePreferred sh

// the used value of 'width' is calculated from the constraint equation used for block-level, non-replaced elements in normal flow.

if (computedHeightIsAuto && !hasIntrinsicWidth && !hasIntrinsicHeight) {

if (shouldComputePreferred == ComputePreferred)

- return 0;

+ return computeReplacedLogicalWidthRespectingMinMaxWidth(0, ComputePreferred);

// The aforementioned 'constraint equation' used for block-level, non-replaced elements in normal flow:

// 'margin-left' + 'border-left-width' + 'padding-left' + 'width' + 'padding-right' + 'border-right-width' + 'margin-right' = width of containing block

LayoutUnit logicalWidth = containingBlock()->availableLogicalWidth();

« no previous file with comments | « no previous file | no next file » | no next file with comments »