Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1637323002: Editing: Tidy up HTML document structure before execCommand(). (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9, dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Tidy up HTML document structure before execCommand(). A crash of crbug.com/537815 was due to an editable <p> as document.documentElement. Supporting such invalid HTML structure is costly. So we correct such HTML structure before executing execCommands. - We show a console warning if the autocorrection happens. - After the autocorrection, document.write() doesn't work because the document tree is complete. BUG=537815 Committed: https://crrev.com/18a1a860db010e852016004215f2fc854faf2135 Cr-Commit-Position: refs/heads/master@{#371774}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Revert the Node.cpp change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/editing/editability/empty-document-delete.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/editability/empty-document-delete-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/editability/empty-document-justify-right.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/editability/empty-document-justify-right-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/editability/empty-document-stylewithcss-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/append-node-under-document-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/delete-empty-container-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/insert-html-to-document-element-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/insert-line-break-onload.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/execCommand/insert-line-break-onload-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-separator-crash2.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tkent
yosin@, would you review this please?
4 years, 11 months ago (2016-01-27 07:37:37 UTC) #4
yosin_UTC9
lgtm Node.cpp has a change introduced by crrev.com/1639193002 You may want to exclude Node.cpp from ...
4 years, 11 months ago (2016-01-27 08:38:05 UTC) #5
tkent
https://codereview.chromium.org/1637323002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/1637323002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode1537 third_party/WebKit/Source/core/dom/Node.cpp:1537: if (hasEditableStyle()) On 2016/01/27 at 08:38:04, Yosi_UTC9 wrote: > ...
4 years, 11 months ago (2016-01-27 08:48:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637323002/40001
4 years, 11 months ago (2016-01-27 08:51:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-27 11:51:54 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/18a1a860db010e852016004215f2fc854faf2135 Cr-Commit-Position: refs/heads/master@{#371774}
4 years, 11 months ago (2016-01-27 11:52:50 UTC) #12
esprehn
This patch is definitely not right, any document with a non <html> documentElement will get ...
4 years, 5 months ago (2016-07-12 21:23:16 UTC) #13
esprehn
On 2016/07/12 at 21:23:16, esprehn wrote: > This patch is definitely not right, any document ...
4 years, 5 months ago (2016-07-12 21:28:16 UTC) #14
tkent
We understand this is a ugly hack, and no other browsers do it. However, we'd ...
4 years, 5 months ago (2016-07-13 04:41:40 UTC) #15
dglazkov
On 2016/07/13 at 04:41:40, tkent wrote: > We understand this is a ugly hack, and ...
4 years, 5 months ago (2016-07-13 14:55:57 UTC) #16
tkent
4 years, 5 months ago (2016-07-14 00:15:05 UTC) #17
Message was sent while issue was closed. 
We thought we didn't need intent-to-implement because this was trivial and had
almost no risk.  We assumed HTML documents usually had the root <html>, and this
didn't work for practical web applications.

I'll add a TODO comment and a UseCounter.

Powered by Google App Engine
This is Rietveld 408576698