third_party/WebKit/Source/core/dom/Document.cpp - Issue 1637323002: Editing: Tidy up HTML document structure before execCommand().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1637323002: Editing: Tidy up HTML document structure before execCommand(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert the Node.cpp change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash-expected.txt ('k') | third_party/WebKit/Source/core/editing/Editor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 281497ca4858358e3a6b229b6f1806410ff59386..76d4a7909fe66b354a962780f9ddc73a63d190a3 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -4455,6 +4455,7 @@ bool Document::execCommand(const String& commandName, bool, const String& value,

// Postpone DOM mutation events, which can execute scripts and change

// DOM tree against implementation assumption.

EventQueueScope eventQueueScope;

+ Editor::tidyUpHTMLStructure(*this);

Editor::Command editorCommand = command(this, commandName);

Platform::current()->histogramSparse("WebCore.Document.execCommand", editorCommand.idForHistogram());

return editorCommand.execute(value);