third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-separator-crash2.html - Issue 1637323002: Editing: Tidy up HTML document structure before execCommand().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-separator-crash2.html

Issue 1637323002: Editing: Tidy up HTML document structure before execCommand(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert the Node.cpp change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/execCommand/insert-line-break-onload-expected.txt ('k') | third_party/WebKit/LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(function() {

	6 var p = document.createElement('p');

	7 document.replaceChild(p, document.documentElement);

	8 p.innerHTML = '<form>\n<p>\n<ruby>\n<rb>\n</rb></ruby></p><table>\n</table>< /form>\n<ruby>\n<p>\n</p><table></table></ruby>';

	9 var s = document.querySelector('rb').firstChild;

	10 var e = document.querySelector('table');

	11 var ol = document.createElement('ol');

	12 ol.innerHTML = '\n<li>\n\n</li>\n';

	13 e.insertBefore(ol, e.firstChild);

	14 var r = document.createRange();

	15 r.setStart(s, 0);

	16 r.setEnd(e, 1);

	17 window.getSelection().removeAllRanges();

	18 window.getSelection().addRange(r);

	19 document.designMode = 'on';

	20 document.execCommand('InsertParagraph');

	21 }, 'InsertParagraph command should not crash with editable P root element.');

	22 </script>

OLD	NEW