Issue 163703004: Revert 250823 "With --site-per-process, avoid a crash when a sub..."

Issue 163703004: Revert 250823 "With --site-per-process, avoid a crash when a sub..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)

Modified:
6 years, 10 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 250823 "With --site-per-process, avoid a crash when a sub..." Speculative revert to see if the navigation changes here are causing sync_integration_tests to fail on: http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11217 > With --site-per-process, avoid a crash when a subframe process goes away. > > We need to clear out the children of any nodes that are affected by the > crash, not the entire FrameTree. > > BUG=338508 > TEST=Killing an iframe process with --site-per-process shows a green rectangle. > R=ajwong@chromium.org, nasko@chromium.org > > Review URL: https://codereview.chromium.org/156303004 TBR=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251090

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -98 lines)			Patch
M	trunk/src/content/browser/frame_host/frame_tree.h	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	trunk/src/content/browser/frame_host/frame_tree.cc	View	2 chunks	+1 line, -20 lines	0 comments	Download
M	trunk/src/content/browser/frame_host/frame_tree_node.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/frame_host/frame_tree_node.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/site_per_process_browsertest.cc	View	1 chunk	+0 lines, -62 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

Committed patchset #1 manually as r251090 (tree was closed).

6 years, 10 months ago (2014-02-13 18:35:07 UTC) #2

Charlie Reis

Why was this CL suspected in the sync failure? I don't yet see a connection.

6 years, 10 months ago (2014-02-13 18:52:30 UTC) #3

Alexei Svitkine (slow)

None of the other more obvious CLs seem to have helped, looking at things that ...

6 years, 10 months ago (2014-02-13 19:00:48 UTC) #4

Charlie Reis

6 years, 10 months ago (2014-02-13 19:01:33 UTC) #5

Ok, thanks.

On Thu, Feb 13, 2014 at 11:00 AM, Alexei Svitkine
<asvitkine@chromium.org>wrote:

> None of the other more obvious CLs seem to have helped, looking at things
> that may impact navigation.
>
> But right now, it doesn't look like this was the cause. I will revert the
> revert once things are well.
>
>
> On Thu, Feb 13, 2014 at 1:52 PM, <creis@chromium.org> wrote:
>
>> Why was this CL suspected in the sync failure?  I don't yet see a
>> connection.
>>
>> https://codereview.chromium.org/163703004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages