Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1636893003: Remove some summary TODOs that have already been addressed. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove some summary TODOs that have already been addressed. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f93e2d32122c9af569d6103a079f503f9d0d2e2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +0 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-26 19:09:58 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-26 19:11:00 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-26 19:13:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f93e2d32122c9af569d6103a079f503f9d0d2e2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698