Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: pkg/analyzer/tool/summary/idl.dart

Issue 1636893003: Remove some summary TODOs that have already been addressed. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_common.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * This file is an "idl" style description of the summary format. It is not 6 * This file is an "idl" style description of the summary format. It is not
7 * executed directly; instead it is parsed and transformed into code that 7 * executed directly; instead it is parsed and transformed into code that
8 * implements the summary format. 8 * implements the summary format.
9 * 9 *
10 * The code generation process introduces the following non-typical semantics: 10 * The code generation process introduces the following non-typical semantics:
(...skipping 1147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 * file. 1158 * file.
1159 */ 1159 */
1160 @informative 1160 @informative
1161 int uriEnd; 1161 int uriEnd;
1162 } 1162 }
1163 1163
1164 /** 1164 /**
1165 * Unlinked summary information about a specific name contributed by a 1165 * Unlinked summary information about a specific name contributed by a
1166 * compilation unit to a library's public namespace. 1166 * compilation unit to a library's public namespace.
1167 * 1167 *
1168 * TODO(paulberry): add a count of generic parameters, so that resynthesis
1169 * doesn't have to peek into the library to obtain this info.
1170 *
1171 * TODO(paulberry): some of this information is redundant with information 1168 * TODO(paulberry): some of this information is redundant with information
1172 * elsewhere in the summary. Consider reducing the redundancy to reduce 1169 * elsewhere in the summary. Consider reducing the redundancy to reduce
1173 * summary size. 1170 * summary size.
1174 */ 1171 */
1175 class UnlinkedPublicName { 1172 class UnlinkedPublicName {
1176 /** 1173 /**
1177 * The name itself. 1174 * The name itself.
1178 */ 1175 */
1179 String name; 1176 String name;
1180 1177
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
1455 int propagatedTypeSlot; 1452 int propagatedTypeSlot;
1456 1453
1457 /** 1454 /**
1458 * If this variable is inferrable, nonzero slot id identifying which entry in 1455 * If this variable is inferrable, nonzero slot id identifying which entry in
1459 * [LinkedLibrary.types] contains the inferred type for this variable. If 1456 * [LinkedLibrary.types] contains the inferred type for this variable. If
1460 * there is no matching entry in [LinkedLibrary.types], then no type was 1457 * there is no matching entry in [LinkedLibrary.types], then no type was
1461 * inferred for this variable, so its static type is `dynamic`. 1458 * inferred for this variable, so its static type is `dynamic`.
1462 */ 1459 */
1463 int inferredTypeSlot; 1460 int inferredTypeSlot;
1464 } 1461 }
OLDNEW
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_common.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698