Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1636893003: Remove some summary TODOs that have already been addressed. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/test/src/summary/summary_common.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/resynthesize.dart
diff --git a/pkg/analyzer/lib/src/summary/resynthesize.dart b/pkg/analyzer/lib/src/summary/resynthesize.dart
index 274f9436e8d772d18f85c2cb21701ddd1848c658..5089d2500fdb6f1db4ac2b308fd480710f989749 100644
--- a/pkg/analyzer/lib/src/summary/resynthesize.dart
+++ b/pkg/analyzer/lib/src/summary/resynthesize.dart
@@ -442,7 +442,6 @@ class _LibraryResynthesizer {
*/
void buildEnum(UnlinkedEnum serializedEnum) {
assert(!isCoreLibrary);
- // TODO(paulberry): add offset support (for this element type and others)
ClassElementImpl classElement =
new ClassElementImpl(serializedEnum.name, serializedEnum.nameOffset);
classElement.enum2 = true;
@@ -549,8 +548,6 @@ class _LibraryResynthesizer {
} else {
implicitVariable.setter = executableElement;
}
- // TODO(paulberry): do the right thing when getter and setter are in
- // different units.
break;
default:
// The only other executable type is a constructor, and that is handled
@@ -769,8 +766,6 @@ class _LibraryResynthesizer {
*/
ImportElement buildImport(UnlinkedImport serializedImport, int dependency) {
bool isSynthetic = serializedImport.isImplicit;
- // TODO(paulberry): it seems problematic for the offset to be 0 for
- // non-synthetic imports, since it is used to disambiguate location.
ImportElementImpl importElement =
new ImportElementImpl(isSynthetic ? -1 : serializedImport.offset);
String absoluteUri = summaryResynthesizer.sourceFactory
@@ -985,11 +980,6 @@ class _LibraryResynthesizer {
return currentTypeParameters[
currentTypeParameters.length - type.paramReference].type;
} else {
- // TODO(paulberry): handle references to things other than classes (note:
- // this should only occur in the case of erroneous code).
- // TODO(paulberry): test reference to something inside a part.
- // TODO(paulberry): test reference to something inside a part of the
- // current lib.
LinkedReference referenceResolution =
linkedUnit.references[type.reference];
String name;
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/test/src/summary/summary_common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698