Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 1636813003: Remove checks for a crasher in PasswordForm. (Closed)

Created:
4 years, 11 months ago by vabr (Chromium)
Modified:
4 years, 11 months ago
Reviewers:
vasilii
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove checks for a crasher in PasswordForm. The associated bug got closed, the crash is no longer observed since version 43, so the checks are overdue to be removed. BUG=486931, 510952 R=vasilii@chromium.org Committed: https://crrev.com/219d99a6d0790cbc7711b9f37fb63cc61de26bff Cr-Commit-Position: refs/heads/master@{#371507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/common/password_form.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/common/password_form.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vabr (Chromium)
Hi Vasilii, PTAL. Thanks! Vaclav
4 years, 11 months ago (2016-01-26 13:56:29 UTC) #1
vasilii
lgtm
4 years, 11 months ago (2016-01-26 14:07:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636813003/1
4 years, 11 months ago (2016-01-26 14:31:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 14:37:10 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 14:38:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/219d99a6d0790cbc7711b9f37fb63cc61de26bff
Cr-Commit-Position: refs/heads/master@{#371507}

Powered by Google App Engine
This is Rietveld 408576698