Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1636813003: Remove checks for a crasher in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/common/password_form.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_state.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc
index 8f2cfcc39a3d5e986da51557aa3288c0812c005b..fc1b18a1a0cf177d97848720e6caa5ee37ffe623 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc
@@ -152,8 +152,7 @@ void ManagePasswordsState::OnAutomaticPasswordSave(
void ManagePasswordsState::OnPasswordAutofilled(
const PasswordFormMap& password_form_map,
const GURL& origin) {
- // TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed.
- CHECK(!password_form_map.empty());
+ DCHECK(!password_form_map.empty());
ClearData();
if (password_form_map.begin()->second->is_public_suffix_match) {
// Don't show the UI for PSL matched passwords. They are not stored for this
« no previous file with comments | « no previous file | components/autofill/core/common/password_form.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698