Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: components/autofill/core/common/password_form.h

Issue 1636813003: Remove checks for a crasher in PasswordForm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 // 'navigator.credentials.request()' without user interaction. 252 // 'navigator.credentials.request()' without user interaction.
253 // Once user selects this credential the flag is reseted. 253 // Once user selects this credential the flag is reseted.
254 bool skip_zero_click; 254 bool skip_zero_click;
255 255
256 // The layout as determined during parsing. Default value is LAYOUT_OTHER. 256 // The layout as determined during parsing. Default value is LAYOUT_OTHER.
257 Layout layout; 257 Layout layout;
258 258
259 // If true, this form was parsed using Autofill predictions. 259 // If true, this form was parsed using Autofill predictions.
260 bool was_parsed_using_autofill_predictions; 260 bool was_parsed_using_autofill_predictions;
261 261
262 // TODO(vabr): Remove |is_alive| once http://crbug.com/486931 is fixed.
263 bool is_alive; // Set on construction, reset on destruction.
264
265 // If true, this match was found using public suffix matching. 262 // If true, this match was found using public suffix matching.
266 bool is_public_suffix_match; 263 bool is_public_suffix_match;
267 264
268 // If true, this is a credential saved through an Android application, and 265 // If true, this is a credential saved through an Android application, and
269 // found using affiliation-based match. 266 // found using affiliation-based match.
270 bool is_affiliation_based_match; 267 bool is_affiliation_based_match;
271 268
272 // Return true if we consider this form to be a change password form. 269 // Return true if we consider this form to be a change password form.
273 // We use only client heuristics, so it could include signup forms. 270 // We use only client heuristics, so it could include signup forms.
274 bool IsPossibleChangePasswordForm() const; 271 bool IsPossibleChangePasswordForm() const;
(...skipping 28 matching lines...) Expand all
303 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>; 300 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>;
304 301
305 // For testing. 302 // For testing.
306 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout); 303 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
307 std::ostream& operator<<(std::ostream& os, const PasswordForm& form); 304 std::ostream& operator<<(std::ostream& os, const PasswordForm& form);
308 std::ostream& operator<<(std::ostream& os, PasswordForm* form); 305 std::ostream& operator<<(std::ostream& os, PasswordForm* form);
309 306
310 } // namespace autofill 307 } // namespace autofill
311 308
312 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 309 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
OLDNEW
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.cc ('k') | components/autofill/core/common/password_form.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698