Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1636503006: Merge to XFA: War on #defines, part 1. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: War on #defines, part 1. Contains additional XFA-specific changes. Original Review URL: https://codereview.chromium.org/1632143002 . (cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5) R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8e5cd19d174f259bfda5f7a9699b08fdc4289b56

Patch Set 1 : Original merge result #

Patch Set 2 : New XFA-only changes. #

Patch Set 3 : Stray ! #

Total comments: 2

Patch Set 4 : Dircet -> Direct typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -255 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 10 chunks +35 lines, -37 lines 0 comments Download
M core/include/fpdfapi/fpdf_pageobj.h View 4 chunks +13 lines, -29 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 14 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 7 chunks +20 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 9 chunks +10 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 17 chunks +49 lines, -46 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 11 chunks +21 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 2 3 4 chunks +12 lines, -14 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fontmgr.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Tom Sepez
On 2016/01/26 20:09:18, Tom Sepez wrote: > mailto:tsepez@chromium.org changed reviewers: > + mailto:thestig@chromium.org Lei, please ...
4 years, 11 months ago (2016-01-26 20:09:38 UTC) #3
Tom Sepez
On 2016/01/26 20:09:38, Tom Sepez wrote: > On 2016/01/26 20:09:18, Tom Sepez wrote: > > ...
4 years, 11 months ago (2016-01-26 20:13:41 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1636503006/diff/40001/fpdfsdk/src/fpdfsave.cpp File fpdfsdk/src/fpdfsave.cpp (right): https://codereview.chromium.org/1636503006/diff/40001/fpdfsdk/src/fpdfsave.cpp#newcode155 fpdfsdk/src/fpdfsave.cpp:155: if (pDataSetsDircetObj && pDataSetsDircetObj->IsStream()) { Also typo
4 years, 11 months ago (2016-01-26 21:15:52 UTC) #5
Tom Sepez
Committed patchset #4 (id:60001) manually as 8e5cd19d174f259bfda5f7a9699b08fdc4289b56 (presubmit successful).
4 years, 11 months ago (2016-01-26 21:20:31 UTC) #7
Tom Sepez
4 years, 11 months ago (2016-01-26 21:20:54 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1636503006/diff/40001/fpdfsdk/src/fpdfsave.cpp
File fpdfsdk/src/fpdfsave.cpp (right):

https://codereview.chromium.org/1636503006/diff/40001/fpdfsdk/src/fpdfsave.cp...
fpdfsdk/src/fpdfsave.cpp:155: if (pDataSetsDircetObj &&
pDataSetsDircetObj->IsStream()) {
On 2016/01/26 21:15:52, Lei Zhang wrote:
> Also typo

Done.

Powered by Google App Engine
This is Rietveld 408576698