xfa/src/fxfa/src/app/xfa_fontmgr.cpp - Issue 1636503006: Merge to XFA: War on #defines, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/app/xfa_fontmgr.cpp

Issue 1636503006: Merge to XFA: War on #defines, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Dircet -> Direct typo. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/app/xfa_fontmgr.cpp

diff --git a/xfa/src/fxfa/src/app/xfa_fontmgr.cpp b/xfa/src/fxfa/src/app/xfa_fontmgr.cpp

index 02f3d5e4b63f7657e3fdd2f2a975b7319f7130c1..0c3f636dd25e39c7498f87fe0c2ea60a96e7186f 100644

--- a/xfa/src/fxfa/src/app/xfa_fontmgr.cpp

+++ b/xfa/src/fxfa/src/app/xfa_fontmgr.cpp

@@ -1871,7 +1871,7 @@ IFX_Font* CXFA_PDFFontMgr::FindFont(CFX_ByteString strPsName,

continue;

}

CPDF_Object* pDirect = pObj->GetDirect();

- if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {

+ if (!pDirect || !pDirect->IsDictionary()) {

return NULL;

}

CPDF_Dictionary* pFontDict = (CPDF_Dictionary*)pDirect;

« no previous file with comments | « xfa/src/fxfa/src/app/xfa_ffdoc.cpp ('k') | no next file » | no next file with comments »