Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1632143002: War on #defines, part 1. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

War on #defines, part 1. Make the two fundamental "object" types be enums. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/66a9dc9dd65ed2b9c7ede448d046b770140f16d5

Patch Set 1 #

Patch Set 2 : Add const. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -228 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 1 10 chunks +35 lines, -37 lines 0 comments Download
M core/include/fpdfapi/fpdf_pageobj.h View 4 chunks +13 lines, -29 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 14 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 7 chunks +20 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 9 chunks +10 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 17 chunks +49 lines, -46 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 11 chunks +21 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Pls. review.
4 years, 11 months ago (2016-01-26 00:58:34 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-26 01:41:41 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-26 19:47:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
66a9dc9dd65ed2b9c7ede448d046b770140f16d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698