Allow and ignore the googLeakyBucket constraint.

Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729
Committed: https://crrev.com/eac0ccddbbc380e8960228a7989e31a8135fa209
Cr-Commit-Position: refs/heads/master@{#372372}

[hta - Chromium, 2016-01-27 10:48:24]

Patchset #1 (id:1) has been deleted

[hta - Chromium, 2016-01-27 10:49:02]

Description was changed from

==========
Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729
==========

to

==========
Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729
==========

[hta - Chromium, 2016-01-27 10:49:02]

hta@chromium.org changed reviewers:
+ jochen@chromium.org, miu@chromium.org

[hta - Chromium, 2016-01-27 10:50:00]

Miu, can you patch this into code that doesn't have your patch, and see if your
test case runs then?

Looking at the logs, I found two constraints I hadn't seen before. I'm starting
a collection.

[jochen (gone - plz use gerrit), 2016-01-28 08:54:37]

https://codereview.chromium.org/1636403002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
(right):

https://codereview.chromium.org/1636403002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp:362:
WTF_LOG(Media, "Obsolete constraint %s passed",
constraint.m_name.utf8().c_str());
is it reasonable to log something to the console (I doubt any developer will
look at wtf logs)?

[hta - Chromium, 2016-01-28 14:52:51]

More like this?

[jochen (gone - plz use gerrit), 2016-01-28 15:20:39]

lgtm

[hta - Chromium, 2016-01-28 18:47:54]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-01-28 18:49:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636403002/40001

[commit-bot: I haz the power, 2016-01-28 19:58:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 19:58:41]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[miu, 2016-01-28 21:11:47]

not lgtm yet:

https://codereview.chromium.org/1636403002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
(right):

https://codereview.chromium.org/1636403002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp:132:
const char kEnableAutoThrottling[] = "enableAutoThrottling";
Please remove this one (enableAutoThrottling).  This was never passed to the
getUserMedia() API.  This is only used by the chrome.tabCapture API and is
filtered-out before constraints are handed-off to gUM.

[hta - Chromium, 2016-01-29 06:59:51]

Removed the autoThrottling constraint from special treatment. Looks better?

(also made sure to log to console only on mandatory constraints.)

https://codereview.chromium.org/1636403002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
(right):

https://codereview.chromium.org/1636403002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp:132:
const char kEnableAutoThrottling[] = "enableAutoThrottling";
On 2016/01/28 21:11:46, miu wrote:
> Please remove this one (enableAutoThrottling).  This was never passed to the
> getUserMedia() API.  This is only used by the chrome.tabCapture API and is
> filtered-out before constraints are handed-off to gUM.

I wondered where it came from... took it off your log file.
Removed!

[hta - Chromium, 2016-01-29 07:00:14]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 07:00:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636403002/80001

[commit-bot: I haz the power, 2016-01-29 08:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 08:32:49]

Dry run: This issue passed the CQ dry run.

[miu, 2016-01-29 17:46:21]

The CQ bit was checked by miu@chromium.org

[miu, 2016-01-29 17:46:21]

lgtm

[miu, 2016-01-29 17:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1636403002/#ps80001
(title: "Removing enableAutoThrottling special treatment")

[commit-bot: I haz the power, 2016-01-29 17:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636403002/80001

[commit-bot: I haz the power, 2016-01-29 17:55:08]

Description was changed from

==========
Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729
==========

to

==========
Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729
==========

[commit-bot: I haz the power, 2016-01-29 17:55:09]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-29 17:56:54]

Description was changed from

==========
Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729
==========

to

==========
Allow and ignore the googLeakyBucket constraint.

The API has been inconsistent about whether unknown mandatory
constraints were ignored or not; recent tightening meant that
it was always an error.
googLeakyBucket has been used in the past, and should therefore
be allowed.

BUG=579729

Committed: https://crrev.com/eac0ccddbbc380e8960228a7989e31a8135fa209
Cr-Commit-Position: refs/heads/master@{#372372}
==========

[commit-bot: I haz the power, 2016-01-29 17:56:55]

Patchset 4 (id:??) landed as
https://crrev.com/eac0ccddbbc380e8960228a7989e31a8135fa209
Cr-Commit-Position: refs/heads/master@{#372372}