Allow and ignore the googLeakyBucket constraint.

third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 104 matching lines @@
 const char kScreencastMinBitrate[] = "googScreencastMinBitrate";
 const char kCpuOveruseDetection[] = "googCpuOveruseDetection";
 const char kCpuUnderuseThreshold[] = "googCpuUnderuseThreshold";
 const char kCpuOveruseThreshold[] = "googCpuOveruseThreshold";
 const char kCpuUnderuseEncodeRsdThreshold[] = "googCpuUnderuseEncodeRsdThreshold";
 const char kCpuOveruseEncodeRsdThreshold[] = "googCpuOveruseEncodeRsdThreshold";
 const char kCpuOveruseEncodeUsage[] = "googCpuOveruseEncodeUsage";
 const char kHighStartBitrate[] = "googHighStartBitrate";
 const char kPayloadPadding[] = "googPayloadPadding";
 // End of names from libjingle
+// Names that have been used in the past, but should now be ignored.
+// Kept around for backwards compatibility.
+// https://crbug.com/579729
+const char kGoogLeakyBucket[] = "googLeakyBucket";
+const char kEnableAutoThrottling[] = "enableAutoThrottling";
 
 // Names used for testing.
 const char kTestConstraint1[] = "valid_and_supported_1";
 const char kTestConstraint2[] = "valid_and_supported_2";
 
 static bool parseMandatoryConstraintsDictionary(const Dictionary& mandatoryConstraintsDictionary, WebVector<WebMediaConstraint>& mandatory)
 {
     Vector<WebMediaConstraint> mandatoryConstraintsVector;
     HashMap<String, String> mandatoryConstraintsHashMap;
     bool ok = mandatoryConstraintsDictionary.getOwnPropertiesAsStringHashMap(mandatoryConstraintsHashMap);
@@ skipping 210 matching lines @@
         } else if (constraint.m_name.equals(kCpuUnderuseEncodeRsdThreshold)) {
             result.googCpuUnderuseEncodeRsdThreshold.setExact(atoi(constraint.m_value.utf8().c_str()));
         } else if (constraint.m_name.equals(kCpuOveruseEncodeRsdThreshold)) {
             result.googCpuOveruseEncodeRsdThreshold.setExact(atoi(constraint.m_value.utf8().c_str()));
         } else if (constraint.m_name.equals(kCpuOveruseEncodeUsage)) {
             result.googCpuOveruseEncodeUsage.setExact(toBoolean(constraint.m_value));
         } else if (constraint.m_name.equals(kHighStartBitrate)) {
             result.googHighStartBitrate.setExact(atoi(constraint.m_value.utf8().c_str()));
         } else if (constraint.m_name.equals(kPayloadPadding)) {
             result.googPayloadPadding.setExact(toBoolean(constraint.m_value));
+        } else if (constraint.m_name.equals(kGoogLeakyBucket)
+            || constraint.m_name.equals(kEnableAutoThrottling)) {
+            WTF_LOG(Media, "Obsolete constraint %s passed", constraint.m_name.utf8().c_str());

[jochen (gone - plz use gerrit), 2016/01/28 08:54:37]

is it reasonable to log something to the console (I doubt any developer will
look at wtf logs)?

         } else if (constraint.m_name.equals(kTestConstraint1)
             || constraint.m_name.equals(kTestConstraint2)) {
             // These constraints are only for testing parsing.
             // Values 0 and 1 are legal, all others are a ConstraintError.
             if (!constraint.m_value.equals("0") && !constraint.m_value.equals("1"))
                 errorState.throwConstraintError("Illegal value for constraint", constraint.m_name);
         } else {
             // TODO(hta): UMA stats for unknown constraints passed.
             // https://crbug.com/576613
             WTF_LOG(Media, "Unknown constraint name detected");
@@ skipping 153 matching lines @@
 
 WebMediaConstraints create()
 {
     WebMediaConstraints constraints;
     constraints.initialize();
     return constraints;
 }
 
 } // namespace MediaConstraintsImpl
 } // namespace blink