Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1641653002: Adding counters for the types of Media Constraints. (Closed)

Created:
4 years, 10 months ago by hta - Chromium
Modified:
4 years, 10 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding counters for the types of Media Constraints. This allows us to know who uses the old-style constraints, who uses the new-style constraints, and who uses constraints on APIs that should migrate away from using them. BUG=576613 Committed: https://crrev.com/cd77a9c86c77724b967b611f9554c5a52d27ebf0 Cr-Commit-Position: refs/heads/master@{#372083}

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 23 (11 generated)
hta - Chromium
Review, please? Guido, who did you use as reviewer for your counter CLs?
4 years, 10 months ago (2016-01-27 14:45:15 UTC) #3
Guido Urdaneta
On 2016/01/27 14:45:15, hta - Chromium wrote: > Review, please? > > Guido, who did ...
4 years, 10 months ago (2016-01-27 15:00:31 UTC) #4
hta - Chromium
Adding Jochen as webkit reviewer + isherman for histogram.xml
4 years, 10 months ago (2016-01-27 15:05:05 UTC) #6
Ilya Sherman
histograms.xml lgtm
4 years, 10 months ago (2016-01-28 02:25:34 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-01-28 08:55:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641653002/1
4 years, 10 months ago (2016-01-28 08:57:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/123062) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-01-28 09:00:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641653002/20001
4 years, 10 months ago (2016-01-28 10:46:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/108223)
4 years, 10 months ago (2016-01-28 12:39:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641653002/20001
4 years, 10 months ago (2016-01-28 12:47:27 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 14:08:26 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 14:09:34 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd77a9c86c77724b967b611f9554c5a52d27ebf0
Cr-Commit-Position: refs/heads/master@{#372083}

Powered by Google App Engine
This is Rietveld 408576698