third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h - Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

index b4b9f2d43c5950fff03b8095e1a01c38fb5f3c75..7db5b6c8949a593134dc3d0620c53d9ca92ad204 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

@@ -44,7 +44,6 @@ namespace blink {

class InjectedScript;

class InjectedScriptManager;

class JSONArray;

-class ScriptState;

class V8DebuggerImpl;

typedef String ErrorString;

@@ -93,8 +92,8 @@ public:

private:

InjectedScriptManager* injectedScriptManager() { return m_injectedScriptManager; }

- void reportExecutionContextCreated(ScriptState*, const String& type, const String& origin, const String& humanReadableName, const String& frameId) override;

- void reportExecutionContextDestroyed(ScriptState*) override;

+ void reportExecutionContextCreated(v8::Local<v8::Context>, const String& type, const String& origin, const String& humanReadableName, const String& frameId) override;

+ void reportExecutionContextDestroyed(v8::Local<v8::Context>) override;

RefPtr<JSONObject> m_state;

InspectorFrontend::Runtime* m_frontend;