Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp
index aceecc241d5503944ab7ed0a63606f743e6c4e10..2f94c35b7db41eee8b424d29a3103174267b284f 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp
@@ -30,7 +30,6 @@
#include "core/inspector/v8/V8RuntimeAgentImpl.h"
-#include "bindings/core/v8/ScriptState.h"
#include "core/inspector/InjectedScript.h"
#include "core/inspector/InjectedScriptManager.h"
#include "core/inspector/RemoteObjectId.h"
@@ -207,11 +206,11 @@ void V8RuntimeAgentImpl::disable(ErrorString* errorString)
m_enabled = false;
}
-void V8RuntimeAgentImpl::reportExecutionContextCreated(ScriptState* scriptState, const String& type, const String& origin, const String& humanReadableName, const String& frameId)
+void V8RuntimeAgentImpl::reportExecutionContextCreated(v8::Local<v8::Context> context, const String& type, const String& origin, const String& humanReadableName, const String& frameId)
{
if (!m_enabled)
return;
- InjectedScript* injectedScript = injectedScriptManager()->injectedScriptFor(scriptState);
+ InjectedScript* injectedScript = injectedScriptManager()->injectedScriptFor(context);
if (!injectedScript)
return;
RefPtr<ExecutionContextDescription> description = ExecutionContextDescription::create()
@@ -225,9 +224,9 @@ void V8RuntimeAgentImpl::reportExecutionContextCreated(ScriptState* scriptState,
}
-void V8RuntimeAgentImpl::reportExecutionContextDestroyed(ScriptState* scriptState)
+void V8RuntimeAgentImpl::reportExecutionContextDestroyed(v8::Local<v8::Context> context)
{
- int contextId = injectedScriptManager()->discardInjectedScriptFor(scriptState);
+ int contextId = injectedScriptManager()->discardInjectedScriptFor(context);
if (m_enabled)
m_frontend->executionContextDestroyed(contextId);
}
« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698