Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h
index c70f1c43c288cf237fd0bc92c3f13a07e40bc5f1..18a1265a2e0562db9cae7be4bd500c593ac20a7d 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h
+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h
@@ -11,13 +11,14 @@
#include "wtf/Forward.h"
#include "wtf/Noncopyable.h"
+#include <v8.h>
+
namespace blink {
class InjectedScript;
class InjectedScriptManager;
class JSONArray;
class JSONObject;
-class ScriptState;
class V8Debugger;
typedef String ErrorString;
@@ -65,8 +66,8 @@ public:
virtual void setCustomObjectFormatterEnabled(ErrorString*, bool) = 0;
// Embedder callbacks.
- virtual void reportExecutionContextCreated(ScriptState*, const String& type, const String& origin, const String& humanReadableName, const String& frameId) = 0;
- virtual void reportExecutionContextDestroyed(ScriptState*) = 0;
+ virtual void reportExecutionContextCreated(v8::Local<v8::Context>, const String& type, const String& origin, const String& humanReadableName, const String& frameId) = 0;
+ virtual void reportExecutionContextDestroyed(v8::Local<v8::Context>) = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698