content/public/test/mock_render_thread.cc - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/mock_render_thread.cc

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Added FrameTreeHelpers::createLocalChild. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/mock_render_thread.cc

diff --git a/content/public/test/mock_render_thread.cc b/content/public/test/mock_render_thread.cc

index f5347f193e6a740d6583f207dbb1c448561be418..3f441cceff378d397433a4ac1e5f52541cee6a44 100644

--- a/content/public/test/mock_render_thread.cc

+++ b/content/public/test/mock_render_thread.cc

@@ -214,11 +214,7 @@ void MockRenderThread::OnCreateWindow(

// The Frame expects to be returned a valid route_id different from its own.

void MockRenderThread::OnCreateChildFrame(

- int new_frame_routing_id,

- blink::WebTreeScopeType scope,

- const std::string& frame_name,

- blink::WebSandboxFlags sandbox_flags,

- const blink::WebFrameOwnerProperties& frame_owner_properties,

+ const FrameHostMsg_CreateChildFrame_Params& params,

int* new_render_frame_id) {

*new_render_frame_id = new_frame_routing_id_++;

}

« no previous file with comments | « content/public/test/mock_render_thread.h ('k') | content/renderer/render_frame_impl.h » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')