Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Added FrameTreeHelpers::createLocalChild. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index d9e0a51072abd442d393b0c37a69288e3457309f..42547b8adf7bbf0d76efd9062dda4cc89bd338ff 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -435,13 +435,15 @@ class CONTENT_EXPORT RenderFrameImpl
blink::WebLocalFrame* parent,
blink::WebTreeScopeType scope,
const blink::WebString& name,
- blink::WebSandboxFlags sandboxFlags,
- const blink::WebFrameOwnerProperties& frameOwnerProperties) override;
+ const blink::WebString& unique_name,
+ blink::WebSandboxFlags sandbox_flags,
+ const blink::WebFrameOwnerProperties& frame_owner_properties) override;
void didChangeOpener(blink::WebFrame* frame) override;
void frameDetached(blink::WebFrame* frame, DetachType type) override;
void frameFocused() override;
void willClose(blink::WebFrame* frame) override;
- void didChangeName(const blink::WebString& name) override;
+ void didChangeName(const blink::WebString& name,
+ const blink::WebString& unique_name) override;
void didEnforceStrictMixedContentChecking() override;
void didChangeSandboxFlags(blink::WebFrame* child_frame,
blink::WebSandboxFlags flags) override;

Powered by Google App Engine
This is Rietveld 408576698