content/public/test/mock_render_thread.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/mock_render_thread.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Added FrameTreeHelpers::createLocalChild. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/frame_replication_state.cc ('k') | content/public/test/mock_render_thread.cc » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/mock_render_thread.h

diff --git a/content/public/test/mock_render_thread.h b/content/public/test/mock_render_thread.h

index f2b89ccb815f814a454f0ed0cbe63fdedd85b6f4..c8ae817f9013d226fe9ad41e3ff15d8550d1765c 100644

--- a/content/public/test/mock_render_thread.h

+++ b/content/public/test/mock_render_thread.h

@@ -18,6 +18,7 @@

#include "ipc/message_filter.h"

#include "third_party/WebKit/public/web/WebPopupType.h"

+struct FrameHostMsg_CreateChildFrame_Params;

struct ViewHostMsg_CreateWindow_Params;

struct ViewHostMsg_CreateWindow_Reply;

@@ -126,13 +127,8 @@ class MockRenderThread : public RenderThread {

ViewHostMsg_CreateWindow_Reply* reply);

// The Frame expects to be returned a valid route_id different from its own.

- void OnCreateChildFrame(

- int new_frame_routing_id,

- blink::WebTreeScopeType scope,

- const std::string& frame_name,

- blink::WebSandboxFlags sandbox_flags,

- const blink::WebFrameOwnerProperties& frame_owner_properties,

- int* new_render_frame_id);

+ void OnCreateChildFrame(const FrameHostMsg_CreateChildFrame_Params& params,

+ int* new_render_frame_id);

#if defined(OS_WIN)

void OnDuplicateSection(base::SharedMemoryHandle renderer_handle,