third_party/WebKit/Source/web/tests/FrameTestHelpers.h - Issue 1635873003: Replicating WebFrame::uniqueName across renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3

Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('K') | « third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp » ('j') | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

index 5850282b5d1245236d58ced6fc48398fe6776af0..a3d17ba2a2c55bd258934bbe883de8a621b3fd80 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

@@ -155,7 +155,7 @@ class TestWebFrameClient : public WebFrameClient {

public:

TestWebFrameClient();

- WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags, const WebFrameOwnerProperties&) override;

+ WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, const WebString& frameUniqueName, WebSandboxFlags, const WebFrameOwnerProperties&) override;

void frameDetached(WebFrame*, DetachType) override;

void didStartLoading(bool) override;

void didStopLoading() override;