Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 1635873003: Replicating WebFrame::uniqueName across renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump-render-tree3
Patch Set: Addressed CR feedback from Charlie. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 UseMockScrollbarSettings m_mockScrollbarSettings; 148 UseMockScrollbarSettings m_mockScrollbarSettings;
149 TestWebViewClient* m_testWebViewClient; 149 TestWebViewClient* m_testWebViewClient;
150 }; 150 };
151 151
152 // Minimal implementation of WebFrameClient needed for unit tests that load fram es. Tests that load 152 // Minimal implementation of WebFrameClient needed for unit tests that load fram es. Tests that load
153 // frames and need further specialization of WebFrameClient behavior should subc lass this. 153 // frames and need further specialization of WebFrameClient behavior should subc lass this.
154 class TestWebFrameClient : public WebFrameClient { 154 class TestWebFrameClient : public WebFrameClient {
155 public: 155 public:
156 TestWebFrameClient(); 156 TestWebFrameClient();
157 157
158 WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const We bString& frameName, WebSandboxFlags, const WebFrameOwnerProperties&) override; 158 WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const We bString& frameName, const WebString& frameUniqueName, WebSandboxFlags, const Web FrameOwnerProperties&) override;
159 void frameDetached(WebFrame*, DetachType) override; 159 void frameDetached(WebFrame*, DetachType) override;
160 void didStartLoading(bool) override; 160 void didStartLoading(bool) override;
161 void didStopLoading() override; 161 void didStopLoading() override;
162 162
163 bool isLoading() { return m_loadsInProgress > 0; } 163 bool isLoading() { return m_loadsInProgress > 0; }
164 void waitForLoadToComplete(); 164 void waitForLoadToComplete();
165 165
166 private: 166 private:
167 int m_loadsInProgress; 167 int m_loadsInProgress;
168 }; 168 };
(...skipping 15 matching lines...) Expand all
184 WebDOMMessageEvent) override { } 184 WebDOMMessageEvent) override { }
185 185
186 private: 186 private:
187 RawPtrWillBePersistent<WebRemoteFrameImpl> const m_frame; 187 RawPtrWillBePersistent<WebRemoteFrameImpl> const m_frame;
188 }; 188 };
189 189
190 } // namespace FrameTestHelpers 190 } // namespace FrameTestHelpers
191 } // namespace blink 191 } // namespace blink
192 192
193 #endif // FrameTestHelpers_h 193 #endif // FrameTestHelpers_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698