Replicating WebFrame::uniqueName across renderers.

third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

Index: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
index 09dd04d20f69f950dafe23dd5592a70bb86a7c5d..f22edc9f0c2f01784ffdd8ea4d07cdad12fce4b0 100644
--- a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
+++ b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
@@ -324,7 +324,7 @@ TEST(RemoteFrameThrottlingTest, ThrottledLocalRoot)
     WebFrameOwnerProperties properties;
     FrameTestHelpers::TestWebFrameClient localFrameClient;
     WebRemoteFrame* rootFrame = webView->mainFrame()->toWebRemoteFrame();
-    WebLocalFrame* localFrame = rootFrame->createLocalChild(WebTreeScopeType::Document, "", WebSandboxFlags::None, &localFrameClient, nullptr, properties);
+    WebLocalFrame* localFrame = rootFrame->createLocalChild(WebTreeScopeType::Document, "name", "uniqueName", WebSandboxFlags::None, &localFrameClient, nullptr, properties);

[dcheng, 2016/02/16 22:17:29]

I would have expected name == uniqueName for most of these test cases.

[Łukasz Anforowicz, 2016/02/16 23:39:53]

In product code, we have name == uniqueName for the main frame, but for all
child frames this equality doesn't hold.

Additionally, there are new asserts that will complain when uniqueName.isEmpty
for a child frame (because of this we cannot have name == uniqueName in at least
some cases, like the first modified tests in
content/browser/frame_host/frame_tree_unittest.cc).

That said, I guess it is ok to have name == uniqueName in
FrameThrottlingTest.cpp and WebFrameTest.cpp.  I started making this change, but
I got hesitant - when I see/read |"name", "uniqueName"| I can reasonably guess
what both of these arguments are, but it is not so obvious when reading |"name",
"name"|.

WDYT?

[dcheng, 2016/02/19 18:14:57]

I don't know, it just seems weird to explicitly hardcode something in tests
that's different from what actually happens. Maybe we need a test helper for
createLocalChild / createRemoteChild: it'd probably be reasonable to add this to
FrameTestHelpers. createLocalChild() has a lot of arguments that are almost
always use default values in tests.

[Łukasz Anforowicz, 2016/02/19 19:56:59]

Good idea for introducing a helper - this reduces a lot of
boilerplate/noise/duplication.  OTOH, this still won't do exactly what the
product code would do, because it is not possible to calculate a |uniqueName|
via FrameTree without having a local parent.  Still - cheating in one place with
a comment is probably better than having this spread across multiple tests.

Done... sort-of...

 
     WebString baseURL("http://internal.test/");
     URLTestHelpers::registerMockedURLFromBaseURL(baseURL, "simple_div.html");