Add sandbox ISA and extra compile flag fields to PNaCl translation cache key

ppapi/api/private/ppb_nacl_private.idl

Index: ppapi/api/private/ppb_nacl_private.idl
diff --git a/ppapi/api/private/ppb_nacl_private.idl b/ppapi/api/private/ppb_nacl_private.idl
index 6dfbff7989d7829058dcc923a0b89dbf6ada2bd0..5a6d3d81ce3c03a51066504f1347d59d98df0c12 100644
--- a/ppapi/api/private/ppb_nacl_private.idl
+++ b/ppapi/api/private/ppb_nacl_private.idl
@@ -110,19 +110,18 @@ interface PPB_NaCl_Private {
    */
   PP_FileHandle CreateTemporaryFile([in] PP_Instance instance);
 
-  /* Create a temporary file, which will be deleted by the time the
-   * last handle is closed (or earlier on POSIX systems), to use for
-   * the nexe with the cache information given by |pexe_url|,
-   * |abi_version|, |opt_level|, |last_modified|, |etag|, and
-   * |has_no_store_header|. If the nexe is already present in the
-   * cache, |is_hit| is set to PP_TRUE and the contents of the nexe
-   * will be copied into the temporary file. Otherwise |is_hit| is set
-   * to PP_FALSE and the temporary file will be writeable.  Currently
-   * the implementation is a stub, which always sets is_hit to false
-   * and calls the implementation of CreateTemporaryFile. In a
-   * subsequent CL it will call into the browser which will remember
-   * the association between the cache key and the fd, and copy the
-   * nexe into the cache after the translation finishes.
+  /* Create a temporary file, which will be deleted by the time the last handle
+   * is closed (or earlier on POSIX systems), to use for the nexe with the cache
+   * information given by |pexe_url|, |abi_version|, |opt_level|,
+   * |last_modified|, |etag|, |has_no_store_header|, |sandbox_isa|, and
+   * |extra_flags|. If the nexe is already present in the cache, |is_hit| is set
+   * to PP_TRUE and the contents of the nexe will be copied into the temporary
+   * file. Otherwise |is_hit| is set to PP_FALSE and the temporary file will be
+   * writeable.  Currently the implementation is a stub, which always sets
+   * is_hit to false and calls the implementation of CreateTemporaryFile. In a
+   * subsequent CL it will call into the browser which will remember the
+   * association between the cache key and the fd, and copy the nexe into the
+   * cache after the translation finishes.
    */
   int32_t GetNexeFd([in] PP_Instance instance,
                     [in] str_t pexe_url,
@@ -131,6 +130,8 @@ interface PPB_NaCl_Private {
                     [in] str_t last_modified,
                     [in] str_t etag,
                     [in] PP_Bool has_no_store_header,
+                    [in] str_t sandbox_isa,
+                    [in] str_t extra_flags,

[jschuh, 2014/02/15 15:36:41]

Why are these strings rather than enums/bit-flags? Strings scare me, because
they imply parsing.

                     [out] PP_Bool is_hit,
                     [out] PP_FileHandle nexe_handle,
                     [in] PP_CompletionCallback callback);