Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: ppapi/c/private/ppb_nacl_private.h

Issue 163433015: Add sandbox ISA and extra compile flag fields to PNaCl translation cache key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/c/private/ppb_nacl_private.h
diff --git a/ppapi/c/private/ppb_nacl_private.h b/ppapi/c/private/ppb_nacl_private.h
index 0001148de9c3f033af12e7a4138d98a3026ac06c..ee632354a7b8ead12a9f18193a4a3bfdb7c000e0 100644
--- a/ppapi/c/private/ppb_nacl_private.h
+++ b/ppapi/c/private/ppb_nacl_private.h
@@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
-/* From private/ppb_nacl_private.idl modified Mon Feb 10 11:05:29 2014. */
+/* From private/ppb_nacl_private.idl modified Fri Feb 14 21:39:55 2014. */
#ifndef PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
#define PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
@@ -127,19 +127,18 @@ struct PPB_NaCl_Private_1_0 {
* returns a posix handle to that temporary file.
*/
PP_FileHandle (*CreateTemporaryFile)(PP_Instance instance);
- /* Create a temporary file, which will be deleted by the time the
- * last handle is closed (or earlier on POSIX systems), to use for
- * the nexe with the cache information given by |pexe_url|,
- * |abi_version|, |opt_level|, |last_modified|, |etag|, and
- * |has_no_store_header|. If the nexe is already present in the
- * cache, |is_hit| is set to PP_TRUE and the contents of the nexe
- * will be copied into the temporary file. Otherwise |is_hit| is set
- * to PP_FALSE and the temporary file will be writeable. Currently
- * the implementation is a stub, which always sets is_hit to false
- * and calls the implementation of CreateTemporaryFile. In a
- * subsequent CL it will call into the browser which will remember
- * the association between the cache key and the fd, and copy the
- * nexe into the cache after the translation finishes.
+ /* Create a temporary file, which will be deleted by the time the last handle
+ * is closed (or earlier on POSIX systems), to use for the nexe with the cache
+ * information given by |pexe_url|, |abi_version|, |opt_level|,
+ * |last_modified|, |etag|, |has_no_store_header|, |sandbox_isa|, and
+ * |extra_flags|. If the nexe is already present in the cache, |is_hit| is set
+ * to PP_TRUE and the contents of the nexe will be copied into the temporary
+ * file. Otherwise |is_hit| is set to PP_FALSE and the temporary file will be
+ * writeable. Currently the implementation is a stub, which always sets
+ * is_hit to false and calls the implementation of CreateTemporaryFile. In a
+ * subsequent CL it will call into the browser which will remember the
+ * association between the cache key and the fd, and copy the nexe into the
+ * cache after the translation finishes.
*/
int32_t (*GetNexeFd)(PP_Instance instance,
const char* pexe_url,
@@ -148,6 +147,8 @@ struct PPB_NaCl_Private_1_0 {
const char* last_modified,
const char* etag,
PP_Bool has_no_store_header,
+ const char* sandbox_isa,
+ const char* extra_flags,
PP_Bool* is_hit,
PP_FileHandle* nexe_handle,
struct PP_CompletionCallback callback);

Powered by Google App Engine
This is Rietveld 408576698