Add sandbox ISA and extra compile flag fields to PNaCl translation cache key

ppapi/api/private/ppb_nacl_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* This file contains NaCl private interfaces. This interface is not versioned
  * and is for internal Chrome use. It may change without notice. */
 
 label Chrome {
   M25 = 1.0
@@ skipping 92 matching lines @@
    * component directory, or an invalid handle on failure.
    */
   PP_FileHandle GetReadonlyPnaclFd([in] str_t filename);
 
   /* This creates a temporary file that will be deleted by the time
    * the last handle is closed (or earlier on POSIX systems), and
    * returns a posix handle to that temporary file.
    */
   PP_FileHandle CreateTemporaryFile([in] PP_Instance instance);
 
-  /* Create a temporary file, which will be deleted by the time the
-   * last handle is closed (or earlier on POSIX systems), to use for
-   * the nexe with the cache information given by |pexe_url|,
-   * |abi_version|, |opt_level|, |last_modified|, |etag|, and
-   * |has_no_store_header|. If the nexe is already present in the
-   * cache, |is_hit| is set to PP_TRUE and the contents of the nexe
-   * will be copied into the temporary file. Otherwise |is_hit| is set
-   * to PP_FALSE and the temporary file will be writeable.  Currently
-   * the implementation is a stub, which always sets is_hit to false
-   * and calls the implementation of CreateTemporaryFile. In a
-   * subsequent CL it will call into the browser which will remember
-   * the association between the cache key and the fd, and copy the
-   * nexe into the cache after the translation finishes.
+  /* Create a temporary file, which will be deleted by the time the last handle
+   * is closed (or earlier on POSIX systems), to use for the nexe with the cache
+   * information given by |pexe_url|, |abi_version|, |opt_level|,
+   * |last_modified|, |etag|, |has_no_store_header|, |sandbox_isa|, and
+   * |extra_flags|. If the nexe is already present in the cache, |is_hit| is set
+   * to PP_TRUE and the contents of the nexe will be copied into the temporary
+   * file. Otherwise |is_hit| is set to PP_FALSE and the temporary file will be
+   * writeable.  Currently the implementation is a stub, which always sets
+   * is_hit to false and calls the implementation of CreateTemporaryFile. In a
+   * subsequent CL it will call into the browser which will remember the
+   * association between the cache key and the fd, and copy the nexe into the
+   * cache after the translation finishes.
    */
   int32_t GetNexeFd([in] PP_Instance instance,
                     [in] str_t pexe_url,
                     [in] uint32_t abi_version,
                     [in] uint32_t opt_level,
                     [in] str_t last_modified,
                     [in] str_t etag,
                     [in] PP_Bool has_no_store_header,
+                    [in] str_t sandbox_isa,
+                    [in] str_t extra_flags,

[jschuh, 2014/02/15 15:36:41]

Why are these strings rather than enums/bit-flags? Strings scare me, because
they imply parsing.

                     [out] PP_Bool is_hit,
                     [out] PP_FileHandle nexe_handle,
                     [in] PP_CompletionCallback callback);
 
   /* Report to the browser that translation of the pexe for |instance|
    * has finished, or aborted with an error. If |success| is true, the
    * browser may then store the translation in the cache. The renderer
    * must first have called GetNexeFd for the same instance. (The browser is
    * not guaranteed to store the nexe even if |success| is true; if there is
    * an error on the browser side, or the file is too big for the cache, or
@@ skipping 27 matching lines @@
                      [in] uint64_t loaded_bytes,
                      [in] uint64_t total_bytes);
 
   /* Sets a read-only property on the <embed> DOM element that corresponds to
    * the given instance.
    */
   void SetReadOnlyProperty([in] PP_Instance instance,
                            [in] PP_Var key,
                            [in] PP_Var value);
 };