Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1633983002: Store layoutType in DisplayInfo + misc cleanup (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_576375_display3c_fix_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store layoutType in DisplayInfo + misc cleanup Some cleanup to make the CL extracting the display layout manager JS more managable. BUG=576375 Committed: https://crrev.com/8337dd27609c3aa4713b27cd1ffbb586fdab217f Cr-Commit-Position: refs/heads/master@{#371555}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -59 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.js View 12 chunks +65 lines, -59 lines 2 comments Download

Depends on Patchset:

Issue 1631893003 Patch 1

Dependent Patchsets:

Issue 1626573003 Patch 50004

Messages

Total messages: 9 (3 generated)
stevenjb
This is primarily prep work to make the diff in https://codereview.chromium.org/1626573003/ more managable.
4 years, 11 months ago (2016-01-26 01:20:23 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/1633983002/diff/1/chrome/browser/resources/options/chromeos/display_options.js File chrome/browser/resources/options/chromeos/display_options.js (right): https://codereview.chromium.org/1633983002/diff/1/chrome/browser/resources/options/chromeos/display_options.js#newcode113 chrome/browser/resources/options/chromeos/display_options.js:113: * @return {options.DisplayLayoutType} The position of the calculated ...
4 years, 11 months ago (2016-01-26 17:35:34 UTC) #3
stevenjb
https://codereview.chromium.org/1633983002/diff/1/chrome/browser/resources/options/chromeos/display_options.js File chrome/browser/resources/options/chromeos/display_options.js (right): https://codereview.chromium.org/1633983002/diff/1/chrome/browser/resources/options/chromeos/display_options.js#newcode113 chrome/browser/resources/options/chromeos/display_options.js:113: * @return {options.DisplayLayoutType} The position of the calculated point. ...
4 years, 11 months ago (2016-01-26 18:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633983002/1
4 years, 11 months ago (2016-01-26 18:18:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 19:20:24 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 19:21:25 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8337dd27609c3aa4713b27cd1ffbb586fdab217f
Cr-Commit-Position: refs/heads/master@{#371555}

Powered by Google App Engine
This is Rietveld 408576698