Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1631893003: In display options, lay out the primary display first (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_576375_display3c_fix_0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In display options, lay out the primary display first Fixes a bug introudced in https://codereview.chromium.org/1612083004 when making the external display primary. BUG=576375 Committed: https://crrev.com/952b7129df6b8070e95aacc3d9745ede90532dcd Cr-Commit-Position: refs/heads/master@{#371374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.js View 1 chunk +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
stevenjb
In my previous CL I mistakenly assumed that displays[0] would always be the primary display.
4 years, 11 months ago (2016-01-25 21:35:21 UTC) #2
xiyuan
LGTM but -> bug in CL description. :)
4 years, 11 months ago (2016-01-25 23:00:36 UTC) #3
stevenjb
On 2016/01/25 23:00:36, xiyuan wrote: > LGTM > > but -> bug in CL description. ...
4 years, 11 months ago (2016-01-25 23:22:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631893003/1
4 years, 11 months ago (2016-01-25 23:23:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 00:25:01 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:27:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/952b7129df6b8070e95aacc3d9745ede90532dcd
Cr-Commit-Position: refs/heads/master@{#371374}

Powered by Google App Engine
This is Rietveld 408576698