Extract DisplayLayoutManager from display_options.js

Extract DisplayLayoutManager from display_options.js

This moves the display layout management logic into a separate file
so that it can be replaced with a new layout manager that can handle
3+ displays without affecting 2 monitor behavior.

BUG=576375
Committed: https://crrev.com/00c630fe781d5afe9832fa593c6c68972d08fc4b
Cr-Commit-Position: refs/heads/master@{#371584}

[stevenjb, 2016-01-23 02:20:32]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2016-01-25 18:43:00]

Patchset #2 (id:40001) has been deleted

[stevenjb, 2016-01-26 01:19:10]

Patchset #3 (id:80001) has been deleted

[stevenjb, 2016-01-26 01:31:26]

stevenjb@chromium.org changed reviewers:
+ xiyuan@chromium.org

[stevenjb, 2016-01-26 01:31:26]

Follow up to https://codereview.chromium.org/1633983002/

https://codereview.chromium.org/1626573003/diff/50004/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_layout_manager.js
(right):

https://codereview.chromium.org/1626573003/diff/50004/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_layout_manager.js:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
Note: This is a new file diffing from display_options.js so the diff is a little
odd. (I used a low similarity value so that you can see the actual changes).
Also: This may make more sense if display_options.js is reviewed first.

[xiyuan, 2016-01-26 18:06:53]

lgtm

https://codereview.chromium.org/1626573003/diff/50004/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_options.js (right):

https://codereview.chromium.org/1626573003/diff/50004/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:772:
div.classList.toggle('displays-focused', true);
nit: Can we get rid of the "if" and just do

div.classList.toggle('displays-focused', id == this.focusedId_);

?

[stevenjb, 2016-01-26 19:36:15]

https://codereview.chromium.org/1626573003/diff/50004/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_options.js (right):

https://codereview.chromium.org/1626573003/diff/50004/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:772:
div.classList.toggle('displays-focused', true);
On 2016/01/26 18:06:53, xiyuan wrote:
> nit: Can we get rid of the "if" and just do
> 
> div.classList.toggle('displays-focused', id == this.focusedId_);
> 
> ?

Done.

[stevenjb, 2016-01-26 19:37:10]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-01-26 19:37:11]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1626573003/#ps110001
(title: "Feedback / Rebase")

[commit-bot: I haz the power, 2016-01-26 19:38:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626573003/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626573003/110001

[commit-bot: I haz the power, 2016-01-26 20:38:43]

Committed patchset #4 (id:110001)

[commit-bot: I haz the power, 2016-01-26 20:39:54]

Description was changed from

==========
Extract DisplayLayoutManager from display_options.js

This moves the display layout management logic into a separate file
so that it can be replaced with a new layout manager that can handle
3+ displays without affecting 2 monitor behavior.

BUG=576375
==========

to

==========
Extract DisplayLayoutManager from display_options.js

This moves the display layout management logic into a separate file
so that it can be replaced with a new layout manager that can handle
3+ displays without affecting 2 monitor behavior.

BUG=576375

Committed: https://crrev.com/00c630fe781d5afe9832fa593c6c68972d08fc4b
Cr-Commit-Position: refs/heads/master@{#371584}
==========

[commit-bot: I haz the power, 2016-01-26 20:39:54]

Patchset 4 (id:??) landed as
https://crrev.com/00c630fe781d5afe9832fa593c6c68972d08fc4b
Cr-Commit-Position: refs/heads/master@{#371584}