Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: trunk/Source/core/html/HTMLObjectElement.cpp

Issue 16336010: Revert 150924 "Node::lazyAttach shouldn't lie about being attached" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/html/HTMLDialogElement.cpp ('k') | trunk/Source/core/html/HTMLPlugInImageElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/html/HTMLObjectElement.cpp
===================================================================
--- trunk/Source/core/html/HTMLObjectElement.cpp (revision 151673)
+++ trunk/Source/core/html/HTMLObjectElement.cpp (working copy)
@@ -370,7 +370,7 @@
if (!isImageType()) {
// If we don't think we have an image type anymore, then clear the image from the loader.
m_imageLoader->setImage(0);
- lazyReattach();
+ reattach();
return;
}
}
@@ -378,7 +378,8 @@
m_useFallbackContent = true;
// FIXME: Style gets recalculated which is suboptimal.
- lazyReattach();
+ detach();
+ attach();
}
// FIXME: This should be removed, all callers are almost certainly wrong.
« no previous file with comments | « trunk/Source/core/html/HTMLDialogElement.cpp ('k') | trunk/Source/core/html/HTMLPlugInImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698