Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: trunk/Source/core/html/HTMLPlugInImageElement.cpp

Issue 16336010: Revert 150924 "Node::lazyAttach shouldn't lie about being attached" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/html/HTMLObjectElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/html/HTMLPlugInImageElement.cpp
===================================================================
--- trunk/Source/core/html/HTMLPlugInImageElement.cpp (revision 151673)
+++ trunk/Source/core/html/HTMLPlugInImageElement.cpp (working copy)
@@ -154,9 +154,7 @@
void HTMLPlugInImageElement::willRecalcStyle(StyleChange)
{
- // FIXME: setNeedsWidgetUpdate is used by subclasses to signal that they need
- // their renderer replaced on the next style recalc. It's not clear why they
- // don't just do lazyReattach instead. This code looks like a terrible hack.
+ // FIXME: Why is this necessary? Manual re-attach is almost always wrong.
if (!useFallbackContent() && needsWidgetUpdate() && renderer() && !isImageType())
reattach();
}
« no previous file with comments | « trunk/Source/core/html/HTMLObjectElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698