trunk/Source/core/html/HTMLDialogElement.cpp - Issue 16336010: Revert 150924 "Node::lazyAttach shouldn't lie about being attached"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/core/html/HTMLDialogElement.cpp

Issue 16336010: Revert 150924 "Node::lazyAttach shouldn't lie about being attached" (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/Source/core/html/HTMLDialogElement.cpp

===================================================================

--- trunk/Source/core/html/HTMLDialogElement.cpp (revision 151673)

+++ trunk/Source/core/html/HTMLDialogElement.cpp (working copy)

@@ -98,7 +98,7 @@

m_topIsValid = true;

// FIXME: It's inefficient to reattach here. We could do better by mutating style directly and forcing another layout.

- lazyReattach();

+ reattach();

}

void HTMLDialogElement::show()