[interpreter] Reduce move operations for wide register support.

[interpreter] Reduce move operations for wide register support.

Introduces the concept of transfer direction to register operands. This
enables the register translator to emit exactly the moves that a
bytecode having it's register operands translated needs.

BUG=v8:4280, v8:4675
LOG=N

Committed: https://crrev.com/95bec7e7b1789d7903c4812c51716e09fe241a90
Cr-Commit-Position: refs/heads/master@{#33544}

[oth, 2016-01-26 16:27:16]

oth@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[oth, 2016-01-26 16:27:17]

rmcilroy@chromium.org: Please review all the changes here.

bmeurer@chromium.org: Please review changes in compiler.

Thanks

[rmcilroy, 2016-01-26 16:49:51]

lgtm once comments are addressed.

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (left):

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:411: operand_type !=
OperandType::kReg16) {
Purposefully dropping kReg16 from here?

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecodes.c...
src/interpreter/bytecodes.cc:407: int range = op_type ==
interpreter::OperandType::kRegPair8 ? 1 : 2;
Need to fix this line to deal with new output types (and kReg16 versions too..)

[oth, 2016-01-26 17:55:53]

Thanks, comments incorporated.

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.cc (left):

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.cc:411: operand_type !=
OperandType::kReg16) {
On 2016/01/26 16:49:51, rmcilroy wrote:
> Purposefully dropping kReg16 from here?

Yes, moves to the translation window are not needed for 16-bit register operands
as they are directly addressable by the 16-bit operand.

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):

https://codereview.chromium.org/1633153002/diff/1/src/interpreter/bytecodes.c...
src/interpreter/bytecodes.cc:407: int range = op_type ==
interpreter::OperandType::kRegPair8 ? 1 : 2;
On 2016/01/26 16:49:51, rmcilroy wrote:
> Need to fix this line to deal with new output types (and kReg16 versions
too..)

Done.

[Benedikt Meurer, 2016-01-27 10:14:46]

LGTM on compiler.

[oth, 2016-01-27 11:13:58]

The CQ bit was checked by oth@chromium.org

[oth, 2016-01-27 11:13:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1633153002/#ps60001
(title: "Remove RegisterOperandIsMovable from RegisterMover interface")

[commit-bot: I haz the power, 2016-01-27 11:14:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633153002/60001

[commit-bot: I haz the power, 2016-01-27 11:15:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-27 11:16:05]

Description was changed from

==========
[interpreter] Reduce move operations for wide register support.

Introduces the concept of transfer direction to register operands. This
enables the register translator to emit exactly the moves that a
bytecode having it's register operands translated needs.

BUG=v8:4280,v8:4675
LOG=N
==========

to

==========
[interpreter] Reduce move operations for wide register support.

Introduces the concept of transfer direction to register operands. This
enables the register translator to emit exactly the moves that a
bytecode having it's register operands translated needs.

BUG=v8:4280,v8:4675
LOG=N

Committed: https://crrev.com/95bec7e7b1789d7903c4812c51716e09fe241a90
Cr-Commit-Position: refs/heads/master@{#33544}
==========

[commit-bot: I haz the power, 2016-01-27 11:16:06]

Patchset 4 (id:??) landed as
https://crrev.com/95bec7e7b1789d7903c4812c51716e09fe241a90
Cr-Commit-Position: refs/heads/master@{#33544}