[interpreter] Reduce move operations for wide register support.

src/interpreter/bytecodes.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecodes.h"
 
 #include "src/frames.h"
 #include "src/interpreter/bytecode-traits.h"
 
 namespace v8 {
@@ skipping 244 matching lines @@
   return IsJumpImmediate(bytecode) || IsJumpConstant(bytecode) ||
          IsJumpConstantWide(bytecode);
 }
 
 
 // static
 bool Bytecodes::IsJumpOrReturn(Bytecode bytecode) {
   return bytecode == Bytecode::kReturn || IsJump(bytecode);
 }
 
+// static
+bool Bytecodes::IsRegisterOperandType(OperandType operand_type) {
+  switch (operand_type) {
+#define CASE(Name, _)        \
+  case OperandType::k##Name: \
+    return true;
+    REGISTER_OPERAND_TYPE_LIST(CASE)
+#undef CASE
+#define CASE(Name, _)        \
+  case OperandType::k##Name: \
+    break;
+    NON_REGISTER_OPERAND_TYPE_LIST(CASE)
+#undef CASE
+  }
+  return false;
+}
+
+// static
+bool Bytecodes::IsRegisterInputOperandType(OperandType operand_type) {
+  switch (operand_type) {
+#define CASE(Name, _)        \
+  case OperandType::k##Name: \
+    return true;
+    REGISTER_INPUT_OPERAND_TYPE_LIST(CASE)
+#undef CASE
+#define CASE(Name, _)        \
+  case OperandType::k##Name: \
+    break;
+    NON_REGISTER_OPERAND_TYPE_LIST(CASE)
+    REGISTER_OUTPUT_OPERAND_TYPE_LIST(CASE)
+#undef CASE
+  }
+  return false;
+}
+
+// static
+bool Bytecodes::IsRegisterOutputOperandType(OperandType operand_type) {
+  switch (operand_type) {
+#define CASE(Name, _)        \
+  case OperandType::k##Name: \
+    return true;
+    REGISTER_OUTPUT_OPERAND_TYPE_LIST(CASE)
+#undef CASE
+#define CASE(Name, _)        \
+  case OperandType::k##Name: \
+    break;
+    NON_REGISTER_OPERAND_TYPE_LIST(CASE)
+    REGISTER_INPUT_OPERAND_TYPE_LIST(CASE)
+#undef CASE
+  }
+  return false;
+}
 
 namespace {
 static Register DecodeRegister(const uint8_t* operand_start,
                                OperandType operand_type) {
   switch (Bytecodes::SizeOfOperand(operand_type)) {
     case OperandSize::kByte:
       return Register::FromOperand(*operand_start);
     case OperandSize::kShort:
       return Register::FromWideOperand(ReadUnalignedUInt16(operand_start));
     case OperandSize::kNone: {
@@ skipping 41 matching lines @@
         break;
       case interpreter::OperandType::kIdx16:
         os << "[" << ReadUnalignedUInt16(operand_start) << "]";
         break;
       case interpreter::OperandType::kImm8:
         os << "#" << static_cast<int>(static_cast<int8_t>(*operand_start));
         break;
       case interpreter::OperandType::kMaybeReg8:
       case interpreter::OperandType::kMaybeReg16:
       case interpreter::OperandType::kReg8:
-      case interpreter::OperandType::kReg16: {
+      case interpreter::OperandType::kReg16:
+      case interpreter::OperandType::kRegOut8:
+      case interpreter::OperandType::kRegOut16: {
         Register reg = DecodeRegister(operand_start, op_type);
         if (reg.is_current_context()) {
           os << "<context>";
         } else if (reg.is_function_closure()) {
           os << "<closure>";
         } else if (reg.is_new_target()) {
           os << "<new.target>";
         } else if (reg.is_parameter()) {
           int parameter_index = reg.ToParameterIndex(parameter_count);
           if (parameter_index == 0) {
             os << "<this>";
           } else {
             os << "a" << parameter_index - 1;
           }
         } else {
           os << "r" << reg.index();
         }
         break;
       }
+      case interpreter::OperandType::kRegOutPair8:
+      case interpreter::OperandType::kRegOutPair16:
+      case interpreter::OperandType::kRegOutTriple8:
+      case interpreter::OperandType::kRegOutTriple16:
       case interpreter::OperandType::kRegPair8:
-      case interpreter::OperandType::kRegTriple8:
-      case interpreter::OperandType::kRegPair16:
-      case interpreter::OperandType::kRegTriple16: {
+      case interpreter::OperandType::kRegPair16: {
         Register reg = DecodeRegister(operand_start, op_type);
         int range = op_type == interpreter::OperandType::kRegPair8 ? 1 : 2;

[rmcilroy, 2016/01/26 16:49:51]

Need to fix this line to deal with new output types (and kReg16 versions too..)

[oth, 2016/01/26 17:55:53]

Done.

         if (reg.is_parameter()) {
           int parameter_index = reg.ToParameterIndex(parameter_count);
           DCHECK_GT(parameter_index, 0);
           os << "a" << parameter_index - range << "-" << parameter_index;
         } else {
           os << "r" << reg.index() << "-" << reg.index() + range;
         }
         break;
       }
       case interpreter::OperandType::kNone:
@@ skipping 87 matching lines @@
 }
 
 
 Register Register::new_target() { return Register(kNewTargetRegisterIndex); }
 
 
 bool Register::is_new_target() const {
   return index() == kNewTargetRegisterIndex;
 }
 
-
 int Register::MaxParameterIndex() { return kMaxParameterIndex; }
 
 int Register::MaxRegisterIndex() { return kMaxRegisterIndex; }
 
 int Register::MaxRegisterIndexForByteOperand() { return kMaxReg8Index; }
 
 uint8_t Register::ToOperand() const {
   DCHECK(is_byte_operand());
   return static_cast<uint8_t>(-index_);
 }
@@ skipping 38 matching lines @@
   }
   if (reg5.is_valid() && reg4.index() + 1 != reg5.index()) {
     return false;
   }
   return true;
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8