Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: src/interpreter/register-translator.h

Issue 1633153002: [interpreter] Reduce move operations for wide register support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove RegisterOperandIsMovable from RegisterMover interface Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecodes.cc ('k') | src/interpreter/register-translator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/register-translator.h
diff --git a/src/interpreter/register-translator.h b/src/interpreter/register-translator.h
index 783924d34c92d09d68bc9430b240c7ff08990518..b683a899e2f265e39aca15c9ad01297920f058c6 100644
--- a/src/interpreter/register-translator.h
+++ b/src/interpreter/register-translator.h
@@ -77,7 +77,8 @@ class RegisterTranslator final {
kTranslationWindowLimit - kTranslationWindowLength + 1;
Register TranslateAndMove(Bytecode bytecode, int operand_index, Register reg);
- Register MakeAddressable(Register reg, OperandType reg_type);
+ static bool RegisterIsMovableToWindow(Bytecode bytecode, int operand_index);
+
static Register Translate(Register reg);
RegisterMover* mover() const { return mover_; }
@@ -90,9 +91,12 @@ class RegisterTranslator final {
// translation.
bool emitting_moves_;
- // State for restoring registers after bytecode.
- Register window_registers_[kTranslationWindowLength];
+ // Number of window registers in use.
int window_registers_count_;
+
+ // State for restoring register moves emitted by TranslateOutputRegisters.
+ std::pair<Register, Register> output_moves_[kTranslationWindowLength];
+ int output_moves_count_;
};
// Interface for RegisterTranslator helper class that will emit
@@ -106,11 +110,6 @@ class RegisterMover {
// of this method must be aware that register moves with bad
// register values are a security hole.
virtual void MoveRegisterUntranslated(Register from, Register to) = 0;
-
- // Returns true if the register operand can be moved into the
- // translation window.
- virtual bool RegisterOperandIsMovable(Bytecode bytecode,
- int operand_index) = 0;
};
} // namespace interpreter
« no previous file with comments | « src/interpreter/bytecodes.cc ('k') | src/interpreter/register-translator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698