Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1632603002: [api] Default native data property setter to replace the setter if the property is writable. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Default native data property setter to replace the setter if the property is writable. BUG=chromium:580584 LOG=y Committed: https://crrev.com/997cd3d987fe7e389572fce32e98a272cd514263 Cr-Commit-Position: refs/heads/master@{#33551}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -371 lines) Patch
M src/accessors.h View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M src/accessors.cc View 1 2 23 chunks +88 lines, -323 lines 0 comments Download
M src/api.cc View 8 chunks +23 lines, -23 lines 0 comments Download
M src/api-natives.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/lookup.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 8 chunks +18 lines, -17 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-580584.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-01-26 08:58:13 UTC) #9
Igor Sheludko
lgtm
4 years, 10 months ago (2016-01-26 13:08:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632603002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632603002/130001
4 years, 10 months ago (2016-01-27 08:22:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/12373)
4 years, 10 months ago (2016-01-27 08:29:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632603002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632603002/150001
4 years, 10 months ago (2016-01-27 12:13:51 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/1979)
4 years, 10 months ago (2016-01-27 12:19:35 UTC) #20
Igor Sheludko
lgtm
4 years, 10 months ago (2016-01-27 12:57:19 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632603002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632603002/190001
4 years, 10 months ago (2016-01-27 12:59:34 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:190001)
4 years, 10 months ago (2016-01-27 13:21:58 UTC) #25
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 13:22:29 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/997cd3d987fe7e389572fce32e98a272cd514263
Cr-Commit-Position: refs/heads/master@{#33551}

Powered by Google App Engine
This is Rietveld 408576698